Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing exports needed by our projects #1

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

greedyboi
Copy link
Contributor

@greedyboi greedyboi commented Jan 9, 2024

CHANGES

Scripts:

  • Usage of npx to run tsc as tsc needs typescript to be installed, npx is bundled within npm which holds tsc CLI

ADDED

  • LumConstants that holds all lum related constants
  • LumTypes with types that needed to be explicitly declared (KeyStore, Coin, Account, Log, LogEvent and LogAttribute)
  • LumRegistry which is a registry that holds and exports every txs typeUrl with their corresponding interface
  • LumUtils with all missing utils needed for the wallet and millions (number conversions, encoding, account decoding and others)

Tested locally as a pseudo-released package with yalc on the wallet and millions.

For the wallet, all wallet imports are working as expected (logs into the account, correctly get data from this account especially vesting infos, HDPath edit works correctly as well).
For millions, as we use only offline signers such as Keplr/Cosmostation/Leap, account login and data fetching work as expected (same as the wallet), the rest was only changing the imports source (old -> new sdk)

@greedyboi greedyboi self-assigned this Jan 9, 2024
@Segfaultd
Copy link
Member

Made a few changes on the code to make it cleaner and more aligned with the actual code style.

Please confirm that your test code on Millions & Wallet have no issue working with it.

@Segfaultd Segfaultd merged commit 1c1dfa6 into master Jan 16, 2024
1 of 2 checks passed
@Segfaultd Segfaultd deleted the missing-exports branch January 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants