Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUM-776-3] Leaderboard #30

Merged
merged 5 commits into from
Aug 30, 2023
Merged

[LUM-776-3] Leaderboard #30

merged 5 commits into from
Aug 30, 2023

Conversation

greedyboi
Copy link
Contributor

This PR adds the behavior we wanted on scroll with user rank card being fixed when scrolling the leaderboard in MySavings.
Fixes infinite scroll double fetch when scrolling really fast.
Using amount provided by the api call to calculate the difference between previous ranks and user rank.
Disable your rank part in PoolDetails if your are in the top 4 as you will always see you and your neighbors if you are in the top 4.

@greedyboi greedyboi self-assigned this Aug 24, 2023
@linear
Copy link

linear bot commented Aug 24, 2023

LUM-776

@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Visit the preview URL for this PR (updated for commit 366bb5f):

https://lum-network-millions--pr30-feature-lum-776-m3yn4iy1.web.app

(expires Wed, 06 Sep 2023 16:13:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 935af6f6d3548d5614490046f417fa03e1d208fa

Copy link
Contributor

@ThibaultJRD ThibaultJRD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ThibaultJRD ThibaultJRD merged commit c2f9815 into master Aug 30, 2023
3 checks passed
@ThibaultJRD ThibaultJRD deleted the feature/lum-776 branch August 30, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants