Patch Invalid string false error detection #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 721a92b): https://lum-network-millions--pr49-invalid-string-patch-x80npli0.web.app (expires Tue, 12 Dec 2023 17:30:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 935af6f6d3548d5614490046f417fa03e1d208fa |
|
Visit the preview URL for this PR (updated for commit 721a92b): https://lum-network-millions-testnet--pr49-invalid-string-patc-rc4ym20x.web.app (expires Tue, 12 Dec 2023 17:37:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 3b0b355de2708a87c724a1a9cdc6c671bacc1bb3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects where we detect the invalid string error, previously for the error check we were scoping only errors coming from the blockchain but the error we want to scope comes from runtime (decoding tx events post broadcast, that's my bad 😅).
So we use now a nested try...catch to scope and check runtime errors only, blockchain errors are still thrown in the main try...catch.