Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUM-905] Millions WebApp -> Prepare INJ Pool #67

Merged
merged 9 commits into from
Jun 27, 2024
Merged

Conversation

greedyboi
Copy link
Contributor

CAREFUL

NumbersUtils.convertUnitNumber function signature has changed:

  • New signature: export const convertUnitNumber = (nb: number | string, fromDenom = MICRO_LUM_DENOM, fromMinimalDenom = true): number
  • Because of specific handling of INJ (they don't have a minimal denom and uses exponent), we needed to modify this function and ensure that first it doesn't break anything for classic minimalDenom handling, and as a result, now we must provide the fromDenom (can be undefined and if so we treat it like ulum) and if you want to use it the other way (minimalDenom to normalDenom) you must set the last parameter fromMinimalDenom to false.

@greedyboi greedyboi requested a review from ThibaultJRD May 7, 2024 17:22
@greedyboi greedyboi self-assigned this May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Visit the preview URL for this PR (updated for commit f57d16d):

https://lum-network-millions--pr67-feature-lum-905-y05ywmxf.web.app

(expires Sat, 29 Jun 2024 10:40:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 935af6f6d3548d5614490046f417fa03e1d208fa

@Segfaultd Segfaultd merged commit efab1da into master Jun 27, 2024
3 checks passed
@Segfaultd Segfaultd deleted the feature/lum-905 branch June 27, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants