update examples to show all decorator usages, class components, and custom elements #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trusktr
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the example files to better demonstrate the usage of classy-solid features. The changes showcase more comprehensive examples including effects, memo, component usage, and Custom Elements integration.
Key Changes:
- Refactored examples to demonstrate
@effectdecorators for reactivity tracking within classes - Added examples of Custom Element integration with lifecycle management
- Updated README.md to show
@effectdecorators and thestopEffectsAPI
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/example.ts | Complete rewrite demonstrating Counter/Example classes with effects, MyComp component, and MyElement custom element with lifecycle hooks |
| example/index.html | Removed standalone heading as the examples now render their own content |
| README.md | Updated "At a glance" section to include @effect decorators and stopEffects usage |
| dist/example.js | Generated JavaScript output from transpiled src/example.ts |
| dist/example.js.map | Updated source map for the new example code |
| dist/example.d.ts | Updated TypeScript declarations (now exports empty as classes are not exported) |
| dist/example.d.ts.map | Updated TypeScript declaration source map |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| @component | ||
| class MyComp { | ||
| @signal message = 'Hello, World!' |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.