Skip to content

Commit

Permalink
Rename prop to defaultFaicon
Browse files Browse the repository at this point in the history
  • Loading branch information
colebemis committed Oct 3, 2023
1 parent 2dd288e commit b2cfc4b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/components/markdown.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,7 @@ function NoteLink({ id, text }: NoteLinkProps) {
<NoteFavicon
note={note}
className="mr-2 align-sub [h1>a>&]:align-baseline"
fallback={null}
defaultFavicon={null}
/>
) : null}
{text}
Expand Down
6 changes: 3 additions & 3 deletions src/components/note-favicon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@ import { WebsiteFavicon } from "./website-favicon"

type NoteFaviconProps = React.ComponentPropsWithoutRef<"span"> & {
note: Note
fallback?: React.ReactNode
defaultFavicon?: React.ReactNode
}

export function NoteFavicon({
note,
className,
fallback = <NoteIcon16 data-testid="favicon-default" />,
defaultFavicon = <NoteIcon16 data-testid="favicon-default" />,
...props
}: NoteFaviconProps) {
let icon = fallback
let icon = defaultFavicon

// GitHub
if (typeof note.frontmatter.github === "string") {
Expand Down

0 comments on commit b2cfc4b

Please sign in to comment.