Unship panel layout #301
Merged
Unship panel layout #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lumen-notes ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for lumen-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I was about to open an issue because I thought I broke something. I like the multi-column. |
|
@NetOpWibby That's great feedback. What do you miss about the multi column layout? |
|
No wasted space! And, I got to see multiple notes at once. |
|
@colebemis The screenshot in the README should probably be updated too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the panel system in favor of a simple one-column layout. In practice, the complexity of the panel layout outweighed the benefits. I'm going to ship this one-column layout to see how it feels in day-to-day use.