Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering issue with single dollar signs #312

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

colebemis
Copy link
Member

@colebemis colebemis commented Apr 12, 2024

Closes #309

This pull request addresses the issue of single dollar signs causing rendering problems in markdown content within the src/components/markdown.tsx file. The solution implemented involves modifying the remarkPlugins array to include configuration options for the remarkMath plugin. Specifically, the singleDollarTextMath option is set to false, which prevents single dollar signs from being interpreted as math expressions. This change ensures that text containing single dollar signs is rendered correctly without being mistakenly formatted as mathematical notation. The modification is made directly in the remarkPlugins array where the remarkMath plugin is initialized, ensuring that the configuration applies to all instances of markdown rendering within the component.

Before

image

After

image

For more details, open the Copilot Workspace session.

Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for lumen-notes ready!

Name Link
🔨 Latest commit 482cf9a
🔍 Latest deploy log https://app.netlify.com/sites/lumen-notes/deploys/6618d00ed60c3c0008fdbbdd
😎 Deploy Preview https://deploy-preview-312--lumen-notes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 53
Accessibility: 81
Best Practices: 100
SEO: 67
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for lumen-storybook ready!

Name Link
🔨 Latest commit 482cf9a
🔍 Latest deploy log https://app.netlify.com/sites/lumen-storybook/deploys/6618d00e21210c0008f9f9dc
😎 Deploy Preview https://deploy-preview-312--lumen-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colebemis colebemis marked this pull request as ready for review April 12, 2024 06:11
@colebemis colebemis merged commit a99d8ce into main Apr 12, 2024
11 checks passed
@colebemis colebemis deleted the colebemis/fix-dollar-sign-rendering branch April 12, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird rendering/formatting from "$"
1 participant