Allow a pre-initalized HTTP client to be passed in the client builder #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows a user to re-use an HTTP client to back a soap client. This can be meaningful when trying limit the amount of outstanding connections taken by each client's connection pool. I also modified the accessor of the auth module: ```diff -pub(crate) mod digest; -pub(crate) mod username_token; +pub mod digest; +pub mod username_token; ``` You cleverly allowed the transport to be a generic, so users are free to re-implement their client as they want, but not providing the auth crates mean they have to re-implement everything. This aims to make it a bit more flexible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a user to re-use an HTTP client to back a soap client. This can be meaningful when trying limit the amount of outstanding connections taken by each client's connection pool.
I also modified the accessor of the auth module:
You cleverly allowed the transport to be a generic, so users are free to re-implement their client as they want, but not providing the auth crates mean they have to re-implement everything. This aims to make it a bit more flexible.