Add GraphTensor::repeat with shape rank validation#233
Add GraphTensor::repeat with shape rank validation#233MagellaX wants to merge 2 commits intoluminal-ai:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c11045c5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
any takes @jafioti |
|
I think it looks correct, but I'm going to add back in 'z' striding in tensor strides so that this can be done zero cost (not needing a gather op). |
Sounds good to me. I just wanted to get |
Issue: Closes #226