Skip to content

Comments

Add GraphTensor::repeat with shape rank validation#233

Open
MagellaX wants to merge 2 commits intoluminal-ai:mainfrom
MagellaX:feat/repeat-226
Open

Add GraphTensor::repeat with shape rank validation#233
MagellaX wants to merge 2 commits intoluminal-ai:mainfrom
MagellaX:feat/repeat-226

Conversation

@MagellaX
Copy link

@MagellaX MagellaX commented Feb 6, 2026

Issue: Closes #226

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c11045c5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@MagellaX
Copy link
Author

MagellaX commented Feb 7, 2026

any takes @jafioti

@jafioti
Copy link
Collaborator

jafioti commented Feb 7, 2026

I think it looks correct, but I'm going to add back in 'z' striding in tensor strides so that this can be done zero cost (not needing a gather op).

@MagellaX
Copy link
Author

MagellaX commented Feb 9, 2026

I think it looks correct, but I'm going to add back in 'z' striding in tensor strides so that this can be done zero cost (not needing a gather op).

Sounds good to me. I just wanted to get repeat in with correct behavior first (incl. rank + zero-repeat checks). let me know for the zero-cost stride version as the follow-up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tensor.repeat

2 participants