Enable keyword redirection for trace #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Changed `/cr/trace` response format.
BREAKING CHANGE: Changed default behavior for definition search in `/cr/{rule_id}`
If the trace endpoint is called with a keyword rule, it now supports redirection to the actual definition of that rule, same as the rule endpoint. This necessitated the change of the response from an array to a dict, so that we can send the actual rule that was queried.
I also changed the default of the rule endpoint to *not* default to definition redirection in order to be consistent with the rest of the API.
lunakv
force-pushed
the
add_trace_redirection
branch
from
3a8d6cf to
c08510b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Changed
/cr/traceresponse format.BREAKING CHANGE: Changed default behavior for definition search in
/cr/{rule_id}If the trace endpoint is called with a keyword rule, it now supports redirection to the actual definition of that rule, same as the rule endpoint. This necessitated the change of the response from an array to a dict, so that we can send the actual rule that was queried.
I also changed the default of the rule endpoint to not default to definition redirection in order to be consistent with the rest of the API.