-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pretty): update integer check for Lua5.4 #456
Conversation
I added check for integer ranges in 5.1/5.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to report and fix this issue, including tests and making the original code even easier to read. I think now that tests poss this is ready to go. The release schedule for the next tag where this will appear is usually up to @Tieske.
The AppVeyor tests (Windows) fail. This stuff is hard to get right, since it is platform specific, and probably LuaJIT also deals with these edge cases slightly different. The safest way is probably to try and dynamically test the number ranges supported by the underlying Lua engine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows tests are failing
Unfortunatly string.format code is quite platform and version specific. I'll think how to fix it on next week |
Made runtime calculating min/max integers. I don't see any way to portably format integers without manualy rewriting string.format for integers |
thx! |
Fix #455