Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GitHub workflow actions to latest versions #460

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

deining
Copy link
Contributor

@deining deining commented Jan 31, 2024

This PR bumps GitHub action workflows to latest versions, thus avoiding deprecation warnings.

Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the conventional commits specification to make releases easier on us upstream. In this case the content looks fine but if you could amend the commit with ci: as a prefix that would be appreciated.

@deining deining force-pushed the bump-workflow-actions branch from d4871cf to 582e9bd Compare January 31, 2024 14:48
@deining
Copy link
Contributor Author

deining commented Jan 31, 2024

Please follow the conventional commits specification to make releases easier on us upstream. In this case the content looks fine but if you could amend the commit with ci: as a prefix that would be appreciated.

Done.

@deining deining requested a review from alerque January 31, 2024 14:49
@alerque
Copy link
Member

alerque commented Jan 31, 2024

Hmmm. This has unfortunately run afoul of this upstream issue: leafo/gh-actions-lua#34.

@deining deining force-pushed the bump-workflow-actions branch from 582e9bd to 8322acf Compare January 31, 2024 20:28
@deining
Copy link
Contributor Author

deining commented Jan 31, 2024

Hmmm. This has unfortunately run afoul of this upstream issue: leafo/gh-actions-lua#34.

I see. I am now using leafo/gh-actions-lua@v9, all tests are passing. 😄

@deining deining requested a review from alerque January 31, 2024 20:34
@Tieske Tieske merged commit 8aeebf5 into lunarmodules:master Feb 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants