-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup repository tooling #2
Conversation
yes, agreed. @teto The common approach is to have a |
jobs: | ||
|
||
affected: | ||
uses: lunarmodules/.github/.github/workflows/list_affected_rockspecs.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wyhyat does this do ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link for myself https://github.com/lunarmodules/.github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any time the rockspec files change and are pushed to the default branch, they are tested against several versions of Lua & LuaRocks to make sure they build properly. If they do, it publishes the rockspec to luarocks.
This particular line is a workflow fragment that figures out what, if any, rockspec files have been modified since the last push.
I've already seen that convention, fine by me. I have no experience with github actions so I dont know if this is equivalent but @mrjkb developed an action to push to luarocks https://github.com/nvim-neorocks/luarocks-tag-release on new tags. |
This is the first time I've seen that particular action, but @mrcjkb and I should probably compare notes because it looks like there is a lot of overlap. Or system is probably a bit more opinionated since it was developed specifically to match the conventions we use here on @lunarmodules and wasn't built to be totally generic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as i want to update the nix lua package set, the sooner it's merged and we have a fixed rockspec, the happier I am.
I am happy that the 2 github actions now know about eachother but I wouldn't delay the merge over this.
Sure 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me. Once this is in, the rockspecs can be fixed right?
Yes. Or I can add them here, it doesn't make much difference. Adding them later will produce a CI run failure because it won't be able to republish the existing ones, but that is as intended. |
@alerque whatever works for you I can add the rockspec then |
Go for it. |
Besides these changes we should probably add some rockspecs, for example at least the last published stable version and a dev version just for consistency...