Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup repository tooling #2

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Setup repository tooling #2

merged 2 commits into from
Oct 6, 2023

Conversation

alerque
Copy link
Member

@alerque alerque commented Oct 4, 2023

Besides these changes we should probably add some rockspecs, for example at least the last published stable version and a dev version just for consistency...

@Tieske
Copy link
Member

Tieske commented Oct 4, 2023

yes, agreed.

@teto The common approach is to have a dev rockspec at the toplevel, and released rockspecs in ./rockspecs/. See this repo for an example: https://github.com/lunarmodules/Penlight

jobs:

affected:
uses: lunarmodules/.github/.github/workflows/list_affected_rockspecs.yml@main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wyhyat does this do ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any time the rockspec files change and are pushed to the default branch, they are tested against several versions of Lua & LuaRocks to make sure they build properly. If they do, it publishes the rockspec to luarocks.

This particular line is a workflow fragment that figures out what, if any, rockspec files have been modified since the last push.

@teto
Copy link
Contributor

teto commented Oct 4, 2023

I've already seen that convention, fine by me. I have no experience with github actions so I dont know if this is equivalent but @mrjkb developed an action to push to luarocks https://github.com/nvim-neorocks/luarocks-tag-release on new tags.

@alerque
Copy link
Member Author

alerque commented Oct 4, 2023

This is the first time I've seen that particular action, but @mrcjkb and I should probably compare notes because it looks like there is a lot of overlap. Or system is probably a bit more opinionated since it was developed specifically to match the conventions we use here on @lunarmodules and wasn't built to be totally generic.

Copy link
Contributor

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as i want to update the nix lua package set, the sooner it's merged and we have a fixed rockspec, the happier I am.
I am happy that the 2 github actions now know about eachother but I wouldn't delay the merge over this.

@mrcjkb
Copy link

mrcjkb commented Oct 5, 2023

This is the first time I've seen that particular action, but @mrcjkb and I should probably compare notes because it looks like there is a lot of overlap. Or system is probably a bit more opinionated since it was developed specifically to match the conventions we use here on @lunarmodules and wasn't built to be totally generic.

Sure 😃
The luarocks-tag-release workflow was initially aimed at neovim plugin authors who don't (want) to know about rockspec. But it's meant to be compatible with any luarocks package.
Rather than using the common convention of a rockspecs/ directory, the workflow generates a release rockspec from a template and GitHub metadata.

Copy link
Member

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. Once this is in, the rockspecs can be fixed right?

@alerque
Copy link
Member Author

alerque commented Oct 5, 2023

Yes. Or I can add them here, it doesn't make much difference. Adding them later will produce a CI run failure because it won't be able to republish the existing ones, but that is as intended.

@teto
Copy link
Contributor

teto commented Oct 6, 2023

@alerque whatever works for you I can add the rockspec then

@alerque alerque merged commit 6f6723a into main Oct 6, 2023
4 checks passed
@alerque alerque deleted the retool branch October 6, 2023 14:19
@alerque
Copy link
Member Author

alerque commented Oct 6, 2023

Go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants