Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix url for current rockspec #3

Merged
merged 2 commits into from
Oct 7, 2023
Merged

fix: fix url for current rockspec #3

merged 2 commits into from
Oct 7, 2023

Conversation

teto
Copy link
Contributor

@teto teto commented Oct 6, 2023

@teto
Copy link
Contributor Author

teto commented Oct 7, 2023

I've just added older rockspecs

alerque
alerque approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@teto teto merged commit c33bea6 into main Oct 7, 2023
15 of 26 checks passed
@teto teto deleted the add-updated-rockspec branch October 7, 2023 18:58
@alerque
Copy link
Member

alerque commented Oct 7, 2023

This is going to need a 1.0.0 tag in the repo similar to my comments on iconv.

@alerque
Copy link
Member

alerque commented Oct 7, 2023

This had the same download archive name vs. extracted directory name issue as iconv. I just fixed it via 832f6fd.

@Tieske
Copy link
Member

Tieske commented Oct 8, 2023

just a general remark; I prefer to use the git-repo itself instead of an artifact, so using the "git+https://...." scheme

@alerque
Copy link
Member

alerque commented Oct 9, 2023

@Tieske Sure that works too (we do it on many of the other ones in this org) but doesn't that introduce a git dependency that LuaRocks needs to be able to call? As opposed to the 3 alternative http download agents it can use. Not a big deal probably, just a minor trade off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alerque alerque alerque approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teto @alerque @Tieske