More than triple linter speed #1146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes linting MUCH faster by doing a few things: - Pointing the TypeScript linter at the source files instead of generated files (`"main": "src/foo.ts"` instead of `"main": "build/foo.js"`) - Results in a 50% improvement (28s -> 15s on my machine) - Remove the LunaDefend files from the linter type tree - Results in another ~50% improvement for me (15s -> 8s) - Added `--cache` to the call to ESLint which makes it MUCH faster on commit. The slow part of the linting is because of the `parser: '@typescript-eslint/parser'` bit of the `.eslintrc.js`. That relies on Typescript to generate the import graph and... yeah, it's really slow. There is a fork we could use here: https://github.com/un-es/eslint-plugin-i/ But it was throwing an error when I tried it with one of the rules we use, and even though it was faster, this is now fast enough for me.
factoidforrest
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes linting MUCH faster by doing a few things:
"main": "src/foo.ts"instead of"main": "build/foo.js")--cacheto the call to ESLint which makes it MUCH faster on commit.The slow part of the linting is because of the
parser: '@typescript-eslint/parser'bit of the.eslintrc.js.That relies on Typescript to generate the import graph and... yeah, it's really slow.
There is a fork we could use here: https://github.com/un-es/eslint-plugin-i/
But it was throwing an error when I tried it with one of the rules we use, and even though it was faster, this is now fast enough for me.