Fix async arguments #738
Open
Fix async arguments #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truemedian
reviewed
Dec 17, 2024
src/async.c
Outdated
| asarg->max = max; | ||
| ret = uv_mutex_init(&asarg->mutex); | ||
| if (ret < 0) { // unlikely | ||
| abort(); |
There was a problem hiding this comment.
we shouldn't be aborting the program, this should be reported as a fail
There was a problem hiding this comment.
Fixed in commit 9fa42ef
squeek502
reviewed
Jan 24, 2025
This reverts commit 5827281.
|
I added the FIFO queue because it was mentioned in the issue #505 and made it optional for the sake of compatibility. The issue is quite clear but the fix in this PR is aguable so do not hesitate if you think about any other option. I could remove the queue from this PR, as this is a pure luv feature which will have to be supported in the long run! Thank you for your help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect async
send()arguments using a mutex.Use copy for async arguments rather than Lua reference.
Clear arguments in callback and before sending rather than after.
Keep existing and possibly weird behavior.
Allow async to use a FIFO queue.
Fixes #505