Update github actions to download-artifact and upload-artifact to v4

Author: Matevz Morato

.github/workflows/main.yml

@@ -38,7 +38,7 @@ jobs:
           key: hunter-ubuntu-latest
       - name: List .hunter cache directory
         run: ls -a -l ~/.hunter/_Base/ || true
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: 'recursive'
       - name: Set up Python
@@ -55,7 +55,7 @@ jobs:
       - name: Build target 'pybind11_mkdoc'
         run: cmake --build build --target pybind11_mkdoc --parallel 4
       - name: Upload docstring artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: docstrings
           path: docstrings/
@@ -90,7 +90,7 @@ jobs:
         with:
           submodules: 'recursive'
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: 'docstrings'
           path: docstrings
@@ -145,7 +145,7 @@ jobs:
         with:
           submodules: 'recursive'
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: 'docstrings'
           path: docstrings
@@ -165,9 +165,9 @@ jobs:
           mkdir -p wheelhouse/audited/
           for whl in wheelhouse/preaudited/*linux_armv6l*.whl; do cp "$whl" wheelhouse/audited/$(basename $whl); done
       - name: Archive wheel artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: audited-wheels
+          name: audited-wheels-arm-${{ matrix.rpi-os }}
           path: wheelhouse/audited/
       - name: Deploy wheels to artifactory (if not a release)
         if: startsWith(github.ref, 'refs/tags/v') != true
@@ -197,7 +197,7 @@ jobs:
         with:
           submodules: 'recursive'
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: 'docstrings'
           path: docstrings
@@ -221,9 +221,9 @@ jobs:
       - name: Building wheels
         run: python -m pip wheel . -w ./wheelhouse/audited/ --verbose
       - name: Archive wheel artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: audited-wheels
+          name: audited-wheels-windows-${{ matrix.python-version }}-${{ matrix.python-architecture }}
           path: wheelhouse/audited/
       - name: Deploy wheels to artifactory (if not a release)
         if: startsWith(github.ref, 'refs/tags/v') != true
@@ -256,7 +256,7 @@ jobs:
         with:
           submodules: 'recursive'
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: 'docstrings'
           path: docstrings
@@ -282,9 +282,9 @@ jobs:
       - name: Auditing wheels
         run: ci/repair-whl-macos.sh `pwd`/wheelhouse/* `pwd`/wheelhouse/audited
       - name: Archive wheel artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: audited-wheels
+          name: audited-wheels-macos-x86_64-${{ matrix.python-version }}
           path: wheelhouse/audited/
       - name: Deploy wheels to artifactory (if not a release)
         if: startsWith(github.ref, 'refs/tags/v') != true
@@ -314,7 +314,7 @@ jobs:
         with:
           submodules: 'recursive'
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: 'docstrings'
           path: docstrings
@@ -339,9 +339,9 @@ jobs:
         run: delocate-wheel -v -w wheelhouse/audited wheelhouse/*.whl
 
       - name: Archive wheel artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: audited-wheels
+          name: audited-wheels-macos-arm64
           path: wheelhouse/audited/
       - name: Deploy wheels to artifactory (if not a release)
         if: startsWith(github.ref, 'refs/tags/v') != true
@@ -377,7 +377,7 @@ jobs:
       - name: Create folder structure
         run: mkdir -p wheelhouse/audited/
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: 'docstrings'
           path: docstrings
@@ -403,9 +403,9 @@ jobs:
       - name: Audit wheels
         run: for whl in wheelhouse/*.whl; do auditwheel repair "$whl" --plat $PLAT -w wheelhouse/audited/; done
       - name: Archive wheel artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: audited-wheels
+          name: audited-wheels-linux-x86_64
           path: wheelhouse/audited/
       - name: Deploy wheels to artifactory (if not a release)
         if: startsWith(github.ref, 'refs/tags/v') != true
@@ -439,7 +439,7 @@ jobs:
       - name: Create folder structure
         run: mkdir -p wheelhouse/audited/
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: 'docstrings'
           path: docstrings
@@ -460,9 +460,9 @@ jobs:
       - name: Auditing wheels
         run: for whl in wheelhouse/*.whl; do auditwheel repair "$whl" --plat $PLAT -w wheelhouse/audited/; done
       - name: Archive wheel artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: audited-wheels
+          name: audited-wheels-linux-arm64
           path: wheelhouse/audited/
       - name: Deploy wheels to artifactory (if not a release)
         if: startsWith(github.ref, 'refs/tags/v') != true
@@ -516,9 +516,10 @@ jobs:
       - uses: actions/checkout@v3
         with:
           submodules: 'recursive'
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
-          name: audited-wheels
+          pattern: audited-wheels*
+          merge-multiple: true
           path: wheelhouse/audited/
       - name: List files
         run: ls -lah