Measure: fix linting TaskMeasure.cpp #252
CI_master.yml
on: push
Prepare
/
Prepare
3s
MacOS_13_Conda_Apple
/
Build
47m 27s
Ubuntu_20-04
/
Build
1h 41m
Ubuntu_22-04_Conda
/
Build
1h 41m
Windows
/
Build
17m 44s
Lint
/
Lint
3m 19s
Ubuntu_22-04_Conda_Qt6
/
Build
1h 45m
WrapUp
/
WrapUp
3s
Annotations
1 error and 60 warnings
Lint / Lint
Process completed with exit code 1.
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L44
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L48
{ should almost always be at the end of the previous line [whitespace/braces] [4]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L52
Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L90
Missing space before ( in if( [whitespace/parens] [5]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L106
Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L157
Missing space before ( in for( [whitespace/parens] [5]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L197
Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L235
An else should appear on the same line as the preceding } [whitespace/newline] [4]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L235
If an else has a brace on one side, it should have it on both [readability/braces] [5]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L239
Closing ) should be moved to the previous line [whitespace/parens] [2]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L971
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L1002
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L2197
fmt::detail::specs_setter has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L2233
fmt::detail::dynamic_specs_handler has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L3126
Pass small and trivially-copyable type by value (const signed char &) [-Wclazy-function-args-by-value]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L3127
Pass small and trivially-copyable type by value (const unsigned char &) [-Wclazy-function-args-by-value]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L3128
Pass small and trivially-copyable type by value (const short &) [-Wclazy-function-args-by-value]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L3129
Pass small and trivially-copyable type by value (const unsigned short &) [-Wclazy-function-args-by-value]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L3130
Pass small and trivially-copyable type by value (const long &) [-Wclazy-function-args-by-value]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L55
'modeSwitch' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L66
'valueResult' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L72
use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L73
10 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L90
statement should be inside braces [readability-braces-around-statements]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L131
do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L132
redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L175
do not call c-style vararg functions [cppcoreguidelines-pro-type-vararg]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L184
variable name 's' is too short, expected at least 2 characters [readability-identifier-length]
|
Lint / Lint:
src/Mod/Measure/Gui/TaskMeasure.cpp#L192
the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
|
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(352): conda version: 24.3.0
INFO conda.conda_libmamba_solver.solver:_log_info(353): conda-libmamba-solver version: 24.1.0
|
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(354): libmambapy version: 1.5.8
|
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(355): Target prefix: '/Users/runner/work/FreeCAD/FreeCAD/.conda/freecad'
INFO conda.conda_libmamba_solver.solver:_log_info(356): Command: ['/Users/runner/miniconda3/condabin/mamba', 'update', '--prefix', '.conda/freecad', '--file', 'conda/conda-env.yaml']
|
MacOS_13_Conda_Apple / Build
info libmamba Reading repodata.json file "/var/folders/hw/1f0gcr8d6kn9ms0_wn0_57qc0000gn/T/tmpc98br0ut.json" for repo installed
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 0 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Darwin/23.6.0 OSX/14.6.1 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches 5fef5ecd58e910a9… → 5fef5ecd58e910a9…
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 715638 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Darwin/23.6.0 OSX/14.6.1 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches 63cd651a378e2a3f… → 63cd651a378e2a3f…
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 2050706 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Darwin/23.6.0 OSX/14.6.1 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches c25462d7872987b0… → c25462d7872987b0…
|
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(352): conda version: 24.3.0
INFO conda.conda_libmamba_solver.solver:_log_info(353): conda-libmamba-solver version: 24.1.0
|
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(354): libmambapy version: 1.5.8
|
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(355): Target prefix: '/home/runner/work/FreeCAD/FreeCAD/.conda/freecad'
|
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(356): Command: ['/home/runner/miniconda3/condabin/mamba', 'update', '--prefix', '.conda/freecad', '--file', 'conda/conda-env.yaml']
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 715638 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches 63cd651a378e2a3f… → 63cd651a378e2a3f…
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 1613518 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches c5cc347082717df0… → c5cc347082717df0…
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 2050706 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches c25462d7872987b0… → c25462d7872987b0…
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(352): conda version: 24.3.0
INFO conda.conda_libmamba_solver.solver:_log_info(353): conda-libmamba-solver version: 24.1.0
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(354): libmambapy version: 1.5.8
INFO conda.conda_libmamba_solver.solver:_log_info(355): Target prefix: '/home/runner/work/FreeCAD/FreeCAD/.conda/freecad'
INFO conda.conda_libmamba_solver.solver:_log_info(356): Command: ['/home/runner/miniconda3/condabin/mamba', 'update', '--prefix', '.conda/freecad', '--file', 'conda/conda-env-qt6.yaml']
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 715638 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches 63cd651a378e2a3f… → 63cd651a378e2a3f…
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 1613518 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches c5cc347082717df0… → c5cc347082717df0…
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 2050706 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches c25462d7872987b0… → c25462d7872987b0…
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 6328134 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches 1a2d4b049a0439c9… → 1a2d4b049a0439c9…
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
Lint-10452134990-Logs
|
13.5 KB |
|
MacOS_13_Conda_Apple-10452134990-Logs
|
44.7 KB |
|
Prepare-10452134990-Logs
|
4.05 KB |
|
Ubuntu_20-04-10452134990-Logs
|
179 KB |
|
Ubuntu_22-04_Conda-10452134990-Logs
|
244 KB |
|
Ubuntu_22-04_Conda-Qt6-10452134990-Logs
|
244 KB |
|
Ubuntu_22-04_Conda-Qt6-10452134990-report.md
|
3.76 KB |
|
Windows-10452134990-Logs
|
1.6 MB |
|