Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use correct property for labelling HAL, let users enter property #180

Merged
merged 9 commits into from
Oct 12, 2023

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Sep 21, 2023

Fix #168
Fix #191

TODOs

  • Update HAL vignette

@maelle maelle requested a review from lvaudor September 21, 2023 11:52
databnf,https://data.bnf.fr/sparql
isidore,https://isidore.science/sparql
hal,http://sparql.archives-ouvertes.fr/sparql
name,url,label_property
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lvaudor should some of this be rdfs:name instead?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no I think we're good

@maelle maelle merged commit 29d89e0 into main Oct 12, 2023
7 checks passed
@maelle maelle deleted the labelname branch October 12, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error with spq_label after adding skos:preflabel rdfs:name not systematic for labelling
2 participants