Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rm WikidataQueryServiceR #183

Merged
merged 3 commits into from
Sep 28, 2023
Merged

refactor: rm WikidataQueryServiceR #183

merged 3 commits into from
Sep 28, 2023

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Sep 21, 2023

Fix #174

Will have to be tested on more examples than the ones in the tests.

@maelle maelle requested a review from lvaudor September 28, 2023 09:11
@maelle
Copy link
Collaborator Author

maelle commented Sep 28, 2023

@lvaudor could you please send this on more Wikidata example you might have?

@lvaudor
Copy link
Owner

lvaudor commented Sep 28, 2023

J'ai testé sur qqs exemples Wikidata que j'avais en stock (y'en a plus trop qui font pas partie de la doc à ce stade!) et tout est OK.

@maelle maelle marked this pull request as ready for review September 28, 2023 11:23
@maelle maelle merged commit 8961dae into main Sep 28, 2023
@maelle maelle deleted the HTTR2-FOR-ALL branch September 28, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop WikidataQueryServiceR dependency
2 participants