Throw error in blake2b hashing when size is unreasonable. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=========================================
+ Coverage 97.7% 97.7% +<.01%
=========================================
Files 17 17
Lines 784 786 +2
Branches 2 2
=========================================
+ Hits 766 768 +2
Misses 16 16
Partials 2 2
Continue to review full report at Codecov.
|
lvh
reviewed
Nov 11, 2019
src/caesium/crypto/generichash.clj
Outdated
| (b/call! blake2b buf msg key)) | ||
| buf)) | ||
| (if-not (zero? | ||
| (if (or salt personal) |
There was a problem hiding this comment.
I'd be a little happier if this was factored out into a let to clarify that it's the result of calling blake2b, I think the nesting makes it tricky to read.
lvh
requested changes
Nov 11, 2019
lvh
approved these changes
Nov 18, 2019
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #12.