Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(parser)!: implement dataclass-based parser🧼 #30

Merged
merged 48 commits into from
Jan 10, 2024
Merged

refactor(parser)!: implement dataclass-based parser🧼 #30

merged 48 commits into from
Jan 10, 2024

Conversation

KarelZe
Copy link
Collaborator

@KarelZe KarelZe commented Jan 6, 2024 •
edited
Loading

prepares for #19

Output is equal to old parser.

Improvements:

  • faster
  • deterministic
  • Improved html parsing
  • attachments in messages
  • capable to retrieve more/all messages

Limitations:

@KarelZe KarelZe self-assigned this Jan 6, 2024
@KarelZe KarelZe marked this pull request as draft January 6, 2024 22:17
@KarelZe KarelZe mentioned this pull request Jan 7, 2024
Closed
@KarelZe KarelZe requested a review from lxndrblz January 8, 2024 13:07
@KarelZe KarelZe marked this pull request as ready for review January 8, 2024 13:13
@KarelZe KarelZe mentioned this pull request Jan 8, 2024
Merged
5 tasks
@KarelZe KarelZe changed the title refactor: implement dataclasses 🧼 refactor: implement dataclass-based converter 🧼 Jan 8, 2024
@KarelZe KarelZe changed the title refactor: implement dataclass-based converter 🧼 refactor(parser)!: implement dataclass-based converter 🧼 Jan 9, 2024
@KarelZe KarelZe changed the title refactor(parser)!: implement dataclass-based converter 🧼 refactor(parser)!: implement dataclass-based parser🧼 Jan 9, 2024
lxndrblz
lxndrblz approved these changes Jan 10, 2024
View reviewed changes
Copy link
Owner

@lxndrblz lxndrblz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KarelZe LGTM. Thanks for your hard work.

@lxndrblz lxndrblz merged commit dc2571d into main Jan 10, 2024
1 check passed
@lxndrblz lxndrblz deleted the use-data-classes branch January 10, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxndrblz lxndrblz lxndrblz approved these changes

Assignees

@KarelZe KarelZe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarelZe @lxndrblz