Misc downstream fixes from QGIS #499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Qt::ImMicroFocus Qt::ImMicroFocus has been deprecated in QT 5.14 and has been removed from Qt6. Use its replacement, Qt::ImCursorRectangle instead.
…idButton Qt::MidButton has been deprecated in QT 5.15 and has been removed from Qt6. Use Qt::MiddleButton instead.
…arning about suspicious division by sizeof() in a later memset() call
…nter member variables
and make clang-tidy a bit more smiley
|
Thanks for the efforts and sorry for long delay. Some commits overlap with #474, and I will review that pull request first, which may also take some time. |
Merged
|
Rebase at #516 |
Thank you very much. Let's continue the work there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports a number of fixes from the downstream QGIS project. They've been added downstream to keep compilation warning free and the various code analysis tools used in our workflows happy (cppcheck, coverity, clang-tidy).