Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature / Changes to make easier levels [44] #61

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dskunkler
Copy link
Contributor

@dskunkler dskunkler commented Jan 25, 2022

Fixes #44 Baby mode allows you to use non words, easy splices at 'revel'.

@dskunkler dskunkler changed the title Changes to make easier levels feature / Changes to make easier levels [44] Jan 25, 2022
Copy link

@roryokane roryokane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t try running this version of the code, but after reading the code, I had some suggestions. (I am not an official hello wordl developer, just another user.)

src/Game.tsx Outdated Show resolved Hide resolved
@@ -147,6 +173,8 @@ function App() {
>
{
[
`Guesses don't even need to be real words.`,
`Guesses must be valid dictionary words. Easy mode.`,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s describe what exactly makes this “easy mode”.

Suggested change
`Guesses must be valid dictionary words. Easy mode.`,
`Guesses must be valid dictionary words. Easy mode – the target word will be a common word.`,

@@ -29,12 +29,14 @@ interface GameProps {
keyboardLayout: string;
}

const easyTargets = targetList.slice(0, targetList.indexOf("revel") + 1); // Slightly more frequent word on the list

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“revel” is currently on line 14279 of the wordlist, while “murky” is on line 14502. I don’t think removing 223 possible words out of 14501 will produce a noticeable difference in difficulty. How about halving the search space by splitting on a word around line 7000?

src/App.tsx Outdated
 
<strong>
{["Baby", "Easy", "Normal", "Hard", "Ultra Hard"][difficulty]}
</strong>
<strong>{["Normal", "Hard", "Ultra Hard"][difficulty]}</strong>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried this, but I think this line with the 3 old difficulty values is probably a mistake. As the line above has the new 5. So I guess this line will show them twice in the modes > Easy.

By the way, I guess the &nbsp; 4 lines above was not needed before, and I guess is still not needed. Or does this solve a separate issue?

dskunkler and others added 2 commits February 7, 2022 21:39
…iguous[feature request 44'

Co-authored-by: Rory O’Kane <rory@roryokane.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

easier wordlist please!
3 participants