OpWindow: Redux #10
Merged
OpWindow: Redux #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajroetker
approved these changes
Dec 21, 2023
janveltm
reviewed
Dec 21, 2023
opwindow.go
Outdated
| entries: map[ID]*OpSet{}, | ||
| windowedBy: windowedBy.Nanoseconds(), | ||
| queueHasItems: make(chan struct{}, 1), | ||
| queueHasSpace: make(chan struct{}, 1), |
There was a problem hiding this comment.
Not sure why these need to be buffered
janveltm
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Enqueue()andDequeue().Enqueuenow blocks until first of:opis enqueued, ID has hit max width, context is done, or queue is closedDequeuenow blocks until first of: OpSet is ready, context is canceled, or queue is closed.condinto two different conditions (removes need for extra goroutine to fix missed signals):full(waited byEnqueue(), signaled byDequeue())empty(waited byDequeue, signaled byEnqueue)