Support Numpy 2 #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I'd pinned the dependencies based on what https://github.com/robbievanleeuwen/section-properties required, but it looks like it's fine with Numpy > 2. |
|
I'm playing around locally with getting section-properties to work with numpy2 as well - it is more efficient, especially for cython packages - but I'm running into some weird incompatibilities that I've not figured out yet. Nevertheless, one of the incompatibilities was cytriangle's dependency lock, so this PR is a step toward numpy2 for section-properties as well :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Numpy 2 ... just works on the package you've written. However, it's technically blocked right now because
pyproject.tomlspecificies"numpy": "^1.25.1".In this PR, I'm suggesting swapping the syntax for all dependencies to use
>=instead of^so as to allow next major versions - at least until tests or users advise that those higher versions do not work for some reason. I'm happy to restrict this back to only swappingnumpyhowever, if you'd prefer to lock major versions for pytest and black.