Updating github actions to v4 #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hymccord
approved these changes
Feb 4, 2024
hymccord
requested changes
Feb 4, 2024
There was a problem hiding this comment.
I can find a few occurrences of things that need to be updated
actions/checkout@v3
1x in codeql-analysis.yml
3x in ci.yml
actions/setup-node@v3
2x in ci.yml
1x in publish.yml
Also, upload-artifact@v3 needs to be updated to be v4 since it states that artifacts need to be created with the same version. https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#migration
Good catch. changed others too. Wish we could just do @ vLTS or something instead of doing this every few years |
AardWolf
approved these changes
Feb 4, 2024
hymccord
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure how we can test other than trying to release