Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert GES to stager #556

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Convert GES to stager #556

merged 5 commits into from
Jun 7, 2024

Conversation

hymccord
Copy link
Contributor

@hymccord hymccord commented May 13, 2024 •
edited
Loading

  • Add Gnawnian Express Station stage tests
  • Add Gnawnian Express Station quest type
  • Convert GES to stager and remove obsolete legacy file
  • Convert string ids into numbers during hunt parse

Much of the debug logging removed here is redundant. Any traps changes will be caught by rejection engine.

Fixes: #169

Close: #211 (already done previously)

@hymccord hymccord requested a review from a team as a code owner May 13, 2024 16:57
@hymccord
Copy link
Contributor Author

Last of legacy staging code done!

@AardWolf AardWolf merged commit 0c9d24f into m-h-c-t:main Jun 7, 2024
5 checks passed
@hymccord hymccord deleted the ges-stager branch June 7, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AardWolf AardWolf AardWolf approved these changes

@tsitu tsitu Awaiting requested review from tsitu tsitu is a code owner automatically assigned from m-h-c-t/maintainers

@logicalup logicalup Awaiting requested review from logicalup logicalup is a code owner automatically assigned from m-h-c-t/maintainers

@tehhowch tehhowch Awaiting requested review from tehhowch tehhowch is a code owner automatically assigned from m-h-c-t/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GES Stage Update Gnawnia Express Station Stages Broken
2 participants
@hymccord @AardWolf