Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some basic summary stats for pcap #1037

Closed
wants to merge 11 commits into from
Closed

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Dec 13, 2021

This introduces basic summary stats for pcap files. It introduces "raw" and "a" records, and fields that will hopefully be easy to reach consensus on.

It also adds a small package for decoding pcap files, as the gopacket package is not very efficient. We also have prototype implementations for decoding ethernet, ip, and tcp headers that will be added later.


This change is Reviewable

@gfr10598 gfr10598 force-pushed the sandbox-gfr-pcap-basic branch from 663e82e to 2c11bcd Compare December 13, 2021 14:08
@coveralls
Copy link
Collaborator

coveralls commented Dec 13, 2021

Pull Request Test Coverage Report for Build 7099

  • 155 of 277 (55.96%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 63.635%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/pcap.go 13 21 61.9%
tcpip/tcpip.go 67 89 75.28%
headers/ip.go 72 164 43.9%
Files with Coverage Reduction New Missed Lines %
active/active.go 2 90.63%
Totals Coverage Status
Change from base Build 7057: -0.6%
Covered Lines: 3946
Relevant Lines: 6201

💛 - Coveralls

@gfr10598 gfr10598 force-pushed the sandbox-gfr-pcap-basic branch 5 times, most recently from d3c199e to 366aca1 Compare December 16, 2021 02:55
@gfr10598 gfr10598 force-pushed the sandbox-gfr-pcap-basic branch from 366aca1 to 0ce7165 Compare December 29, 2021 02:07
@stephen-soltesz
Copy link
Contributor

Closing old PR - and referencing the notes from this change in #1085

@stephen-soltesz stephen-soltesz deleted the sandbox-gfr-pcap-basic branch August 12, 2022 17:35
@stephen-soltesz stephen-soltesz restored the sandbox-gfr-pcap-basic branch August 12, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants