Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bqx #98

Merged
merged 2 commits into from
Feb 14, 2020
Merged

Move bqx #98

merged 2 commits into from
Feb 14, 2020

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Feb 13, 2020

Copy the bqx package to cloud, and bqfake package to cloudtest.
Once the clients have been migrated, we can delete the old packages.


This change is Reviewable

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 754

  • 0 of 329 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-17.3%) to 67.598%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cloudtest/bqfake/client.go 0 49 0.0%
cloudtest/bqfake/bqfake.go 0 73 0.0%
cloud/bqx/schema.go 0 207 0.0%
Totals Coverage Status
Change from base Build 747: -17.3%
Covered Lines: 1089
Relevant Lines: 1611

💛 - Coveralls

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: -- are you going to migrate all clients or is there an issue listing and tracking the migration?

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@gfr10598
Copy link
Contributor Author

Added #99 and #100

Copy link
Contributor Author

@gfr10598 gfr10598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create an issue.

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@gfr10598 gfr10598 merged commit d694075 into master Feb 14, 2020
@gfr10598 gfr10598 deleted the move-bqx branch February 14, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants