fix: validate manifest keys to prevent path traversal#165
Open
sanskar0627 wants to merge 1 commit intom-lab:mainfrom
Open
fix: validate manifest keys to prevent path traversal#165sanskar0627 wants to merge 1 commit intom-lab:mainfrom
sanskar0627 wants to merge 1 commit intom-lab:mainfrom
Conversation
Collaborator
|
After listing our project for GSoC, we received a large amount of pull requests across several repositories. We are dealing with the backlog, but this would take time. We will get back to this pull request eventually. In the meanwhile, if you are a GSoC applicant, please read our updated GSoC policy: https://github.com/m-lab/gsoc/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds validation of manifest keys in
diff()to prevent path traversal.Fixes #164
Why
validate_cache_path()currently only validates locally scanned files but is not applied to manifest keys when iterating them indiff(). A corrupted or tampered manifest could include keys like../../etc/cron.d/evil, which would cause downstream consumers (cache pull,cache push) to write files outside the intended data directory.The fix reuses the existing
_validate_cache_path()validator, which already enforces the expectedcache/v1/{timestamp}/{timestamp}/{name}/{file}format and applies it to manifest keys before they're yielded asDiffEntryobjects. Invalid keys are logged and skipped.Changes
_validate_cache_path()to manifest keys indiff(), skipping and logging invalid entries..sequences, and mixed valid/invalid manifestscache pullignores manifests with traversal keysTesting
All 291 tests pass. Ruff and Pyright report no issues.