Skip to content

fix(cloudbuild): use PROJECT_ID instead of custom substitution #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertodauria merged 1 commit into from
Jan 28, 2026
Merged

fix(cloudbuild): use PROJECT_ID instead of custom substitution #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
substitutions:
_REGION: us-east1
_SERVICE_NAME: speed-proxy
_MLAB_PROJECT: mlab-sandbox
_ALLOWED_ORIGIN: https://speed.measurementlab.net

steps:
Expand Down Expand Up @@ -38,7 +37,7 @@ steps:
- |
sed -e "s|OTEL_IMAGE_PLACEHOLDER|${_REGION}-docker.pkg.dev/${PROJECT_ID}/m-lab/otel-collector:${BUILD_ID}|g" \
-e "s|IMAGE_PLACEHOLDER|${_REGION}-docker.pkg.dev/${PROJECT_ID}/m-lab/${_SERVICE_NAME}:${BUILD_ID}|g" \
-e "s|MLAB_PROJECT_PLACEHOLDER|${_MLAB_PROJECT}|g" \
-e "s|MLAB_PROJECT_PLACEHOLDER|${PROJECT_ID}|g" \
-e "s|ALLOWED_ORIGIN_PLACEHOLDER|${_ALLOWED_ORIGIN}|g" \
service.yaml > service-deploy.yaml
gcloud run services replace service-deploy.yaml \
Expand Down
Loading