[WIP] Improvement of testing routines #68
Conversation
AdelekeBankole
force-pushed
the
testing_routines
branch
from
22c2ba9 to
95b1f77
Compare
AdelekeBankole
force-pushed
the
testing_routines
branch
from
95b1f77 to
80bd058
Compare
AdelekeBankole
force-pushed
the
testing_routines
branch
from
80bd058 to
1adf4ce
Compare
There was a problem hiding this comment.
Thanks @AdelekeBankole This looks great, thank you!
We have just run these locally and everything is passing.
Just left a couple of comments for things to check or suggestions to make things a little clearer.
| real(dp), dimension(num_cols, nrf) :: p_cam, p_int_cam | ||
| real(dp), dimension(num_cols, nrf) :: var_cam | ||
| real(dp), dimension(num_cols) :: var_cam_surface | ||
| real(dp), dimension(num_cols) :: ps_cam | ||
| real(dp), dimension(num_cols, nrf) :: var_sam, var_sam_exp |
There was a problem hiding this comment.
These used to be length 48, but now use nrf which is length 30.
Should they be size sam_sounding instead of nrf?
There was a problem hiding this comment.
I think they should be size nrf
There was a problem hiding this comment.
OK, is there a reason for reducing them from 48 to 30?
If we do not test the interpolation above the SAM grid here we should open an issue to say that this is potentially something to be added in future.
Co-authored-by: Jack Atkinson <109271713+jatkinson1000@users.noreply.github.com>
Co-authored-by: Jack Atkinson <109271713+jatkinson1000@users.noreply.github.com>
Co-authored-by: Jack Atkinson <109271713+jatkinson1000@users.noreply.github.com>
Co-authored-by: Jack Atkinson <109271713+jatkinson1000@users.noreply.github.com>
There was a problem hiding this comment.
Thanks @AdelekeBankole
I still have a query around the change of array size, but do not feel it is blocking provided we log this in the issues.
This is great stuff and makes the code more robust, thank you.
| real(dp), dimension(num_cols, nrf) :: p_cam, p_int_cam | ||
| real(dp), dimension(num_cols, nrf) :: var_cam | ||
| real(dp), dimension(num_cols) :: var_cam_surface | ||
| real(dp), dimension(num_cols) :: ps_cam | ||
| real(dp), dimension(num_cols, nrf) :: var_sam, var_sam_exp |
There was a problem hiding this comment.
OK, is there a reason for reducing them from 48 to 30?
If we do not test the interpolation above the SAM grid here we should open an issue to say that this is potentially something to be added in future.
This PR will close #64