-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure Repository #72
Conversation
…tory and move to a CMake build process to generate them.
…return to this we can recover it from git history.
…irectorygit status
…shared test utils and CMakeLists to build all.
…o the CMake tests build process.
Note that I have also removed the SAM interface file that was under development (see 2b3adf3). This is because it is now deprecated and is no longer being pursued. |
One question I have is should we perhaps rename "NN_module" to "YOG_convection"? This would be much clearer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We went through this together this morning and this makes sense. I have some very minor comments below, but otherwise it can be merged.
Regarding the question about the renaming, I agree that "YOG_convection" is a more meaningful name -- this change could be included in this PR
Co-authored-by: Marion <56403724+MarionBWeinzierl@users.noreply.github.com>
Hi @MarionBWeinzierl Made those changes as suggested. |
This should close #71 and #67