Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to test_global_control notebook #103

Closed
wants to merge 2 commits into from

Conversation

dorchard
Copy link
Collaborator

I have been working on this to try to regenerate the figures.

  • Allow forcing data set to be used from path.
  • Line-up output labels
  • Base plot
  • Figure 5
  • Figure 4a
  • Figure 4b
  • Rest

@dorchard dorchard requested a review from raehik November 10, 2023 00:50
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dorchard
Copy link
Collaborator Author

I'm having problems getting Figure 5 using the forcings data alone has some problems:
The pred data set is expected to have S_xscale but this isn't in forcings data set. Any ideas @raehik

@raehik
Copy link
Contributor

raehik commented Nov 29, 2023

complete in #97 with a couple of the changes here added back manually ad05ab0

@dorchard dorchard closed this Nov 30, 2023
@dorchard dorchard deleted the test_global_control_notebook_fix branch December 6, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants