Replace models1 usage with fully_conv_net
#53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once #50 is merged then this can be more easily tested and can also be merged. |
|
On hold while training step execution was being debugged. Looking at this again. I do want a method to compare two neural nets... I believe the architecture should be unchanged, so maybe asserting that is enough? |
|
Related work in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43.
Tasks to complete to close this issue.
fully_conv_netfully_conv_netin TrainScript.pyThere are some known defects in previous PR (#19) which require matching changes in the
models1.pyandfully_conv_net.pymodules. These are:This PR is dependant on #40 and should not be merged until the test is added. This could (optionally) be done as part of this PR.