Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more type annotations #57

Closed
wants to merge 4 commits into from
Closed

Add more type annotations #57

wants to merge 4 commits into from

Conversation

raehik
Copy link
Contributor

@raehik raehik commented Jun 21, 2023

Part of #36 , #16 . The mypy --strict CI runs are failing with a whole load of errors. Many are looking straightforward (and useful) to fill in mechanically. This PR tackles any errors and warnings in mypy logs.

@raehik
Copy link
Contributor Author

raehik commented Oct 25, 2023

Will manually cherry-pick these into larger PRs, #97 or #95 .

@raehik
Copy link
Contributor Author

raehik commented Nov 1, 2023

Closing and manually cherry picking (on my local repo) onto #97 .

@raehik raehik closed this Nov 1, 2023
@raehik
Copy link
Contributor Author

raehik commented Nov 1, 2023

(Remember to delete branch later.)

@raehik
Copy link
Contributor Author

raehik commented Nov 2, 2023

Cherry picked, starts 1f26e83 .

@raehik raehik deleted the raehik-type-annos-mypy branch November 2, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants