Fix & document inference/training step #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
raehik
approved these changes
Sep 14, 2023
|
It would make sense to maybe rename the "testing" directory into "inference", as otherwise people might expect to find software tests in there. |
raehik
changed the title
|
@arthurBarthe , in the Jupyter Notebook there are a lot of sections now labelled "IGNORE THIS". Can we delete these, or what are they used for and why should they be ignored? |
MarionBWeinzierl
approved these changes
Sep 21, 2023
I am doing this renaming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to fix/clean up the inference code (the testing step), and add documentation regarding its use.
- [ ] describe how to load the inference output data from the notebook test_global_control-> This will be done in Notebooks cleanup #82