Rename spinup-evaluation to nemo-spinup-evaluation#119
Open
Conversation
Member
Author
|
I'll delay this PR until testing and data input checks are through |
SimonSadler
requested changes
Mar 13, 2026
Collaborator
SimonSadler
left a comment
SimonSadler
left a comment
There was a problem hiding this comment.
Good to get this done now. The only thing I see is the readme still referring to spinup_evaluation in a few places.
- Rename package from `spinup-evaluation` to `nemo-spinup-evaluation`
for consistency with the other packages in this repo
- Rename import from `spinup_evaluation` to `nemo_spinup_evaluation`
- Rename CLI entry point from `spinup-eval` to `nemo-spinup-evaluation`
- Bump version to 0.3.0 (breaking change: import name has changed)
- Read __version__ dynamically from package metadata to avoid drift
- Update bench README to use named entry points for both forecast and
evaluation CLIs instead of `python -m`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overdue changes to the package name. This will necessitate a bump to 0.3.0.
spinup-evaluationtonemo-spinup-evaluationfor consistency with the other packages in this repospinup_evaluationtonemo_spinup_evaluationspinup-evaltonemo-spinup-evaluationpython -mCloses #107
TODO: