Skip to content

[fossa] Prevent unresolved golang deps from failing analysis. #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zlav
Copy link

@zlav zlav commented Sep 6, 2019

What this PR does / why we need it:

Fixes: fossa analysis

Special notes for your reviewer:
This PR adds the option allow-unresolved to the fossa configuration file in order to handle packages which include manually vendored dependencies which do not have a corresponding revision in their lockfile. This is an issue with sub dependencies that do not explicitly declare their dependencies as opposed to an issue with m3 itself.

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2019

CLA assistant check
All committers have signed the CLA.

vdarulis added a commit that referenced this pull request Sep 6, 2019
@vdarulis
Copy link
Collaborator

vdarulis commented Sep 7, 2019

Thanks! I updated and enabled FOSSA in #1915, including your changes.

@robskillington
Copy link
Collaborator

Closing due to #1915 implementing suggested changes. Thank you @zlav.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants