Support gokart 1.4.0 with some fixed tests #41
+712
−1,006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 14, 2024 15:40
yokomotod
reviewed
Jun 14, 2024
| @@ -27,7 +27,9 @@ isort = "^5.7" | |||
| yapf = ">=0.32" | |||
| toml = "*" | |||
| mypy = "^1.2.0" | |||
| pandas-stubs = "^1.5.3.230321" | |||
| pandas-stubs = "*" | |||
| pyyaml = "6.0.1" | |||
There was a problem hiding this comment.
[question]
new dependency...?
There was a problem hiding this comment.
name = "pyyaml"
-version = "6.0"
+version = "6.0.1"seems not new.
6.0.0 has any issue? I expect we don't need to pin but just require newer than 6.0.1
Suggested change
| pyyaml = "6.0.1" | |
| pyyaml = ">=6.0.1" |
yokomotod
reviewed
Jun 14, 2024
| @@ -50,9 +52,6 @@ ignore_patterns = [ | |||
| line_length = 160 | |||
|
|
|||
| [tool.mypy] | |||
| strict = true | |||
There was a problem hiding this comment.
need to remove strict ?
There was a problem hiding this comment.
@yokomotod
Should it be redirected to @maronuu ?
There was a problem hiding this comment.
Putting that aside, I srtongly disaggree with removing the strict setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the latest gokart
1.4.0in kannon.Changes
1.4.0gokart 1.4.0lockagain to fix build errors innumpy,pyarrow, and etc. That makes the diff in poery.lock large.python 3.12test and removepython 3.8test in CI workflow