-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup styles from Nancy #469
Conversation
## [1.33.1-chore-add-styles-from-nancy.1](v1.33.0...v1.33.1-chore-add-styles-from-nancy.1) (2024-10-08)
## [1.33.1-chore-add-styles-from-nancy.2](v1.33.1-chore-add-styles-from-nancy.1...v1.33.1-chore-add-styles-from-nancy.2) (2024-10-09) ### Bug Fixes * align button on global nav ([d40a067](d40a067)) * trigger Build ([437f4e8](437f4e8))
…ticle/aquarium into chore/add-styles-from-nancy
## [1.33.1-chore-add-styles-from-nancy.3](v1.33.1-chore-add-styles-from-nancy.2...v1.33.1-chore-add-styles-from-nancy.3) (2024-10-10) ### Bug Fixes * worskpace selector button styles ([5c4f54d](5c4f54d))
…re/add-styles-from-nancy
…ticle/aquarium into chore/add-styles-from-nancy
## [1.33.1-chore-add-styles-from-nancy.5](v1.33.1-chore-add-styles-from-nancy.4...v1.33.1-chore-add-styles-from-nancy.5) (2024-10-11) ### Bug Fixes * update build plugin to include types and utils ([822be84](822be84))
…ticle/aquarium into chore/add-styles-from-nancy
## [1.33.1-chore-add-styles-from-nancy.6](v1.33.1-chore-add-styles-from-nancy.5...v1.33.1-chore-add-styles-from-nancy.6) (2024-10-14) ### Bug Fixes * solve conflicts ([375110a](375110a))
…ticle/aquarium into chore/add-styles-from-nancy
## [1.33.1-chore-add-styles-from-nancy.7](v1.33.1-chore-add-styles-from-nancy.6...v1.33.1-chore-add-styles-from-nancy.7) (2024-10-14)
…ub.com/mParticle/aquarium into chore/remove-workspace-button-override
Review Forge |
|
@@ -139,7 +139,7 @@ export function WorkspaceSelector(props: IWorkspaceSelectorProps) { | |||
<Popover | |||
arrow={false} | |||
placement="right" | |||
overlayInnerStyle={{ padding: PaddingXxs }} | |||
overlayInnerStyle={{ padding: PaddingXxs, width: '100%' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for making sure that the sing out button width is 100%. Works as a fix for removing from style.less
.workspaceSelector__signoutButtonContainer {
width: 100%;
}
@@ -131,4 +131,4 @@ | |||
|
|||
.workspaceSelector__signoutButton { | |||
width: 100%; | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This two styles are also for making sure the Sing Out button width is 100% in all the platforms.
.globalNavigation__badge { | ||
margin-left: 4px; | ||
border: solid 1px var(--color-border); | ||
border-radius: var(--border-radius-sm); | ||
padding: 1px var(--padding-content-vertical-sm); | ||
padding: 0; | ||
box-shadow: none !important; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bring this styles to Nancy.
.globalNavigation__badge {
padding: 0;
margin-left: 4px;
}
@@ -0,0 +1,3 @@ | |||
.ant-modal .ant-modal-title { | |||
font-weight: 600 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we moved from 600 to 500 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have this in css --font-weight-strong: 500;
. can we have some centered variable to store it? I really don't want to end up in hard-coded values all over the code (it's what WWE had in Nancy and it was painful)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what change was it, or maybe it's just me, but "Beta" badge in global nav looks bigger. Maybe we can set it to "small" or something, or it's the same as it was?
checked both and they have the same size (@nastyastavitskaya ) |
… ci] ## [1.33.3-chore-remove-workspace-button-override.1](v1.33.2...v1.33.3-chore-remove-workspace-button-override.1) (2024-10-28) ### Bug Fixes * (styles) update global nav icon label text styles ([047c42b](047c42b)) * align button on global nav ([d40a067](d40a067)) * global nav styles cleanup ([d6d64fc](d6d64fc)) * solve conflicts ([375110a](375110a)) * trigger Build ([437f4e8](437f4e8)) * update build plugin to include types and utils ([822be84](822be84)) * update modal font weight ([882fa80](882fa80)) * update package json to try fixing release error ([e6c13c4](e6c13c4)) * worskpace selector button styles ([5c4f54d](5c4f54d))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
🎉 This PR is included in version 1.34.0-fix-semantic-release.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.34.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
This PR migrates styles from Nancy's style.less file into Aquarium.
Components updated
These changes were implemented in the CDP PR, and they can be tested in the PR environment associated with it.
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)