chore: cleanup styles from Nancy #469

gabyzif · 2024-10-22T14:38:45Z

Summary

This PR migrates styles from Nancy's style.less file into Aquarium.

Components updated

These changes were implemented in the CDP PR, and they can be tested in the PR environment associated with it.

Testing Plan

Was this tested locally? If not, explain why.
Was it tested in CDP?
Was it tested in Indicative? Yes, - locally

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Closes https://go.mparticle.com/work/UNI-1138

## [1.33.1-chore-add-styles-from-nancy.1](v1.33.0...v1.33.1-chore-add-styles-from-nancy.1) (2024-10-08)

## [1.33.1-chore-add-styles-from-nancy.2](v1.33.1-chore-add-styles-from-nancy.1...v1.33.1-chore-add-styles-from-nancy.2) (2024-10-09) ### Bug Fixes * align button on global nav ([d40a067](d40a067)) * trigger Build ([437f4e8](437f4e8))

…ticle/aquarium into chore/add-styles-from-nancy

## [1.33.1-chore-add-styles-from-nancy.3](v1.33.1-chore-add-styles-from-nancy.2...v1.33.1-chore-add-styles-from-nancy.3) (2024-10-10) ### Bug Fixes * worskpace selector button styles ([5c4f54d](5c4f54d))

…re/add-styles-from-nancy

## [1.33.1-chore-add-styles-from-nancy.4](v1.33.1-chore-add-styles-from-nancy.3...v1.33.1-chore-add-styles-from-nancy.4) (2024-10-11) ### Bug Fixes * fix issue on prettifier ([#446](#446)) ([03668b6](03668b6)) * update icons that did not obey the color prop ([#445](#445)) ([68006e3](68006e3))

…ticle/aquarium into chore/add-styles-from-nancy

## [1.33.1-chore-add-styles-from-nancy.5](v1.33.1-chore-add-styles-from-nancy.4...v1.33.1-chore-add-styles-from-nancy.5) (2024-10-11) ### Bug Fixes * update build plugin to include types and utils ([822be84](822be84))

…ticle/aquarium into chore/add-styles-from-nancy

## [1.33.1-chore-add-styles-from-nancy.6](v1.33.1-chore-add-styles-from-nancy.5...v1.33.1-chore-add-styles-from-nancy.6) (2024-10-14) ### Bug Fixes * solve conflicts ([375110a](375110a))

…ticle/aquarium into chore/add-styles-from-nancy

## [1.33.1-chore-add-styles-from-nancy.7](v1.33.1-chore-add-styles-from-nancy.6...v1.33.1-chore-add-styles-from-nancy.7) (2024-10-14)

…ub.com/mParticle/aquarium into chore/remove-workspace-button-override

ilyusha · 2024-10-22T14:38:49Z

Review Forge

Click Here for AI Insights

github-actions · 2024-10-22T14:40:31Z

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-28 22:40 UTC

gabyzif · 2024-10-22T14:41:42Z

src/components/navigation/GlobalNavigation/WorkspaceSelector/WorkspaceSelector.tsx

@@ -139,7 +139,7 @@ export function WorkspaceSelector(props: IWorkspaceSelectorProps) {
    <Popover
      arrow={false}
      placement="right"
-      overlayInnerStyle={{ padding: PaddingXxs }}
+      overlayInnerStyle={{ padding: PaddingXxs, width: '100%' }}


This is for making sure that the sing out button width is 100%. Works as a fix for removing from style.less

.workspaceSelector__signoutButtonContainer { width: 100%; }

file here

gabyzif · 2024-10-22T14:43:54Z

src/components/navigation/GlobalNavigation/WorkspaceSelector/workspace-selector.css

@@ -131,4 +131,4 @@

 .workspaceSelector__signoutButton {
  width: 100%;
-}
+}


This two styles are also for making sure the Sing Out button width is 100% in all the platforms.

gabyzif · 2024-10-22T14:45:49Z

src/components/navigation/GlobalNavigation/global-navigation.css

 .globalNavigation__badge {
+  margin-left: 4px;
  border: solid 1px var(--color-border);
  border-radius: var(--border-radius-sm);
-  padding: 1px var(--padding-content-vertical-sm);
+  padding: 0;
  box-shadow: none !important;
 }


This bring this styles to Nancy.

.globalNavigation__badge { padding: 0; margin-left: 4px; }

nastyastavitskaya · 2024-10-23T00:09:12Z

src/components/feedback/Modal/modal.css

@@ -0,0 +1,3 @@
+.ant-modal .ant-modal-title {
+    font-weight: 600


I thought we moved from 600 to 500 🤔

Sanklap said we should move to 600:

And in Nancy it was 600

we have this in css --font-weight-strong: 500; . can we have some centered variable to store it? I really don't want to end up in hard-coded values all over the code (it's what WWE had in Nancy and it was painful)

nastyastavitskaya

I'm not sure what change was it, or maybe it's just me, but "Beta" badge in global nav looks bigger. Maybe we can set it to "small" or something, or it's the same as it was?

gabyzif · 2024-10-23T13:41:38Z

I'm not sure what change was it, or maybe it's just me, but "Beta" badge in global nav looks bigger. Maybe we can set it to "small" or something, or it's the same as it was?

checked both and they have the same size (@nastyastavitskaya )

… ci] ## [1.33.3-chore-remove-workspace-button-override.1](v1.33.2...v1.33.3-chore-remove-workspace-button-override.1) (2024-10-28) ### Bug Fixes * (styles) update global nav icon label text styles ([047c42b](047c42b)) * align button on global nav ([d40a067](d40a067)) * global nav styles cleanup ([d6d64fc](d6d64fc)) * solve conflicts ([375110a](375110a)) * trigger Build ([437f4e8](437f4e8)) * update build plugin to include types and utils ([822be84](822be84)) * update modal font weight ([882fa80](882fa80)) * update package json to try fixing release error ([e6c13c4](e6c13c4)) * worskpace selector button styles ([5c4f54d](5c4f54d))

nastyastavitskaya

lgtm!

mparticle-automation · 2024-10-29T14:46:58Z

🎉 This PR is included in version 1.34.0-fix-semantic-release.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mparticle-automation · 2024-10-29T15:25:55Z

🎉 This PR is included in version 1.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

gabyzif and others added 30 commits October 8, 2024 21:13

chore: adds styles from nancy to aqua

f0c512e

chore(release): 1.33.1-chore-add-styles-from-nancy.1 [skip ci]

53d3a57

## [1.33.1-chore-add-styles-from-nancy.1](v1.33.0...v1.33.1-chore-add-styles-from-nancy.1) (2024-10-08)

fix: trigger Build

437f4e8

fix: align button on global nav

d40a067

fix: worskpace selector button styles

5c4f54d

Merge branch 'chore/add-styles-from-nancy' of https://github.com/mPar…

93ba613

…ticle/aquarium into chore/add-styles-from-nancy

chore(release): 1.33.1-chore-add-styles-from-nancy.3 [skip ci]

cb8661f

## [1.33.1-chore-add-styles-from-nancy.3](v1.33.1-chore-add-styles-from-nancy.2...v1.33.1-chore-add-styles-from-nancy.3) (2024-10-10) ### Bug Fixes * worskpace selector button styles ([5c4f54d](5c4f54d))

Merge branch 'main' of https://github.com/mParticle/aquarium into cho…

200794a

…re/add-styles-from-nancy

chore: update vite config to export types and utils

8d84174

fix: update build plugin to include types and utils

822be84

Merge branch 'chore/add-styles-from-nancy' of https://github.com/mPar…

40ea46f

…ticle/aquarium into chore/add-styles-from-nancy

chore(release): 1.33.1-chore-add-styles-from-nancy.5 [skip ci]

a6462a7

## [1.33.1-chore-add-styles-from-nancy.5](v1.33.1-chore-add-styles-from-nancy.4...v1.33.1-chore-add-styles-from-nancy.5) (2024-10-11) ### Bug Fixes * update build plugin to include types and utils ([822be84](822be84))

chore: update build config to test feature branch

82afd89

Merge branch 'chore/add-styles-from-nancy' of https://github.com/mPar…

52d7034

…ticle/aquarium into chore/add-styles-from-nancy

fix: solve conflicts

375110a

chore(release): 1.33.1-chore-add-styles-from-nancy.6 [skip ci]

34363ca

## [1.33.1-chore-add-styles-from-nancy.6](v1.33.1-chore-add-styles-from-nancy.5...v1.33.1-chore-add-styles-from-nancy.6) (2024-10-14) ### Bug Fixes * solve conflicts ([375110a](375110a))

chore: update changelog

247c05f

Merge branch 'chore/add-styles-from-nancy' of https://github.com/mPar…

72709fb

…ticle/aquarium into chore/add-styles-from-nancy

chore(release): 1.33.1-chore-add-styles-from-nancy.7 [skip ci]

25ff41f

## [1.33.1-chore-add-styles-from-nancy.7](v1.33.1-chore-add-styles-from-nancy.6...v1.33.1-chore-add-styles-from-nancy.7) (2024-10-14)

chore: cleanup vite config

a264edb

Merge branch 'chore/remove-workspace-button-override' of https://gith…

9a536c6

…ub.com/mParticle/aquarium into chore/remove-workspace-button-override

chore: fix conflicts

d3fff7e

chore: rollback vite config

5fd8ca2

chore: (styles) remove unused styles

40986d4

fix: (styles) update global nav icon label text styles

047c42b

Merge branch 'main' into chore/remove-workspace-button-override

87ddf54

chore: (styles) bring styles override from Nancy to aquarium

83dcd10

fix: update package json to try fixing release error

e6c13c4

chore: remove temp fix for fixing release

0906f47

gabyzif commented Oct 22, 2024

View reviewed changes

fix: global nav styles cleanup

d6d64fc

gabyzif requested review from tibuurcio and nastyastavitskaya October 22, 2024 15:21

gabyzif marked this pull request as ready for review October 22, 2024 15:21

nastyastavitskaya reviewed Oct 23, 2024

View reviewed changes

gabyzif added 2 commits October 25, 2024 16:33

Merge branch 'main' into chore/remove-workspace-button-override

16fdf05

fix: update modal font weight

882fa80

gabyzif requested a review from nastyastavitskaya October 28, 2024 11:08

nastyastavitskaya approved these changes Oct 28, 2024

View reviewed changes

tibuurcio approved these changes Oct 28, 2024

View reviewed changes

Merge branch 'main' into chore/remove-workspace-button-override

d157809

gabyzif merged commit e97a8d7 into main Oct 28, 2024
9 checks passed

mparticle-automation added the released on @fix label Oct 29, 2024

mparticle-automation added the released label Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: cleanup styles from Nancy #469

chore: cleanup styles from Nancy #469

gabyzif commented Oct 22, 2024

ilyusha commented Oct 22, 2024

github-actions bot commented Oct 22, 2024 •

edited

Loading

gabyzif Oct 22, 2024 •

edited

Loading

gabyzif Oct 22, 2024

gabyzif Oct 22, 2024

nastyastavitskaya Oct 23, 2024

gabyzif Oct 23, 2024 •

edited

Loading

nastyastavitskaya Oct 23, 2024

nastyastavitskaya left a comment

gabyzif commented Oct 23, 2024

nastyastavitskaya left a comment

mparticle-automation commented Oct 29, 2024

mparticle-automation commented Oct 29, 2024

		@@ -0,0 +1,3 @@
		.ant-modal .ant-modal-title {
		font-weight: 600

chore: cleanup styles from Nancy #469

chore: cleanup styles from Nancy #469

Conversation

gabyzif commented Oct 22, 2024

Summary

Components updated

Testing Plan

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

ilyusha commented Oct 22, 2024

Review Forge

github-actions bot commented Oct 22, 2024 • edited Loading

gabyzif Oct 22, 2024 • edited Loading

Choose a reason for hiding this comment

gabyzif Oct 22, 2024

Choose a reason for hiding this comment

gabyzif Oct 22, 2024

Choose a reason for hiding this comment

nastyastavitskaya Oct 23, 2024

Choose a reason for hiding this comment

gabyzif Oct 23, 2024 • edited Loading

Choose a reason for hiding this comment

nastyastavitskaya Oct 23, 2024

Choose a reason for hiding this comment

nastyastavitskaya left a comment

Choose a reason for hiding this comment

gabyzif commented Oct 23, 2024

nastyastavitskaya left a comment

Choose a reason for hiding this comment

mparticle-automation commented Oct 29, 2024

mparticle-automation commented Oct 29, 2024

github-actions bot commented Oct 22, 2024 •

edited

Loading

gabyzif Oct 22, 2024 •

edited

Loading

gabyzif Oct 23, 2024 •

edited

Loading