chore: update storybook #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Forge |
|
tibuurcio
reviewed
Oct 23, 2024
tibuurcio
reviewed
Oct 24, 2024
Comment on lines
+51
to
+54
|
|
||
| typescript: { | ||
| reactDocgen: 'react-docgen-typescript', | ||
| }, |
There was a problem hiding this comment.
When doing the migration this was prompt:
So basically SB swiched to react-docgen but we had react-docgen-typescript on place and by doing this we are keeping it and not moving to react-docgen.
| @@ -52,6 +52,8 @@ const preview: Preview = { | |||
| }, | |||
| }, | |||
| }, | |||
|
|
|||
| tags: ['autodocs'], | |||
There was a problem hiding this comment.
This happened automatically when doing the upgrade. Before we we had the autodocs placed on main here:
When I was upgrading SB this showed up:
So basically it moved the config to the preview page.
more info here: migration docs
|
🎉 This PR is included in version 1.34.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates Storybook and it's dependencies
Testing Plan
Was this tested locally? If not, explain why.
{explain how this has been tested, and what, if any, additional testing should be done}
Closes https://go.mparticle.com/work/UNI-1021