Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ability to assign badges to stories and dropdown as an example #475

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

tibuurcio
Copy link
Collaborator

@tibuurcio tibuurcio commented Oct 24, 2024

Summary

image

Testing Plan

  • Was this tested locally? If not, explain why.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@ilyusha
Copy link
Collaborator

ilyusha commented Oct 24, 2024

Review Forge

Click Here for AI Insights

Copy link

github-actions bot commented Oct 24, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-24 21:21 UTC

Comment on lines -55 to -56

tags: ['autodocs'],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was recently added while upgrading Storybook versions but it was adding default blank Documentation page files for all component stories. We are doing that manually while we work on documenting components so I'm removing this config.

Copy link
Contributor

@nastyastavitskaya nastyastavitskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's so cool! lgtm 👍

@tibuurcio tibuurcio merged commit 63b5a56 into main Oct 24, 2024
10 checks passed
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants