Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gem to Address Moneybird API Warning Responses #85

Merged
merged 4 commits into from
May 8, 2024
Merged

Update Gem to Address Moneybird API Warning Responses #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d1671e
Add missing attributes to Contact
leandrost Apr 25, 2024
da841c2
Add missing attribute to Invoice::Details
leandrost Apr 25, 2024
965f381
Add missing attributes to SalesInvoice
leandrost Apr 25, 2024
277ccfb
Add missing attribute to TaxRate
leandrost Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/moneybird/resource/contact.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,13 @@ class Contact
address1
address2
administration_id
archived
attention
bank_account
chamber_of_commerce
city
company_name
contact_people
country
created_at
credit_card_number
Expand All @@ -28,6 +30,7 @@ class Contact
id
invoice_workflow_id
lastname
moneybird_payments_mandate
notes
phone
sales_invoices_url
Expand Down
1 change: 1 addition & 0 deletions lib/moneybird/resource/invoice/details.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ class Details
description
id
ledger_account_id
mandatory_tax_text
period
price
product_id
Expand Down
11 changes: 9 additions & 2 deletions lib/moneybird/resource/sales_invoice.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ class SalesInvoice
extend Moneybird::Resource::ClassMethods

has_attributes %i(
attachments
administration_id
attachments
contact
contact_id
contact_person
contact_person_id
created_at
currency
custom_fields
Expand All @@ -16,6 +18,7 @@ class SalesInvoice
document_style_id
draft_id
due_date
events
id
identity_id
invoice_date
Expand All @@ -24,7 +27,9 @@ class SalesInvoice
language
marked_dubious_on
marked_uncollectible_on
next_reminder
notes
original_estimate_id
original_sales_invoice_id
paid_at
paused
Expand All @@ -34,9 +39,12 @@ class SalesInvoice
payments
prices_are_incl_tax
public_view_code
public_view_code_expires_at
recurring_sales_invoice_id
reference
reminder_count
sent_at
short_payment_reference
state
tax_totals
total_discount
Expand All @@ -51,7 +59,6 @@ class SalesInvoice
url
version
workflow_id
events
)

def notes=(notes)
Expand Down
3 changes: 2 additions & 1 deletion lib/moneybird/resource/tax_rate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ class TaxRate
tax_rate_type
show_tax
active
country
created_at
updated_at
)
end
end
end
Loading