Updated code for extraction #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashankmc
requested changes
Mar 14, 2024
There was a problem hiding this comment.
https://code.visualstudio.com/docs/python/linting -- If you areusing visual studio code, please check linting, add a linter and/or a formatter - https://code.visualstudio.com/docs/python/formatting
There was a problem hiding this comment.
Are the class methods for operative part actually being called for testing? For the previous tests, methods are called under main ; Not sure what's happening here?
|
|
||
|
|
||
|
|
||
| # one=self.html_page_structure_one() |
There was a problem hiding this comment.
Why is unused code still part of the PR?
| three.append(y.text) | ||
| return three | ||
|
|
||
|
|
There was a problem hiding this comment.
You need to clean up such that this sticks to PEP8 standard. Unnecessary new lines and indentation in code. Please lint your code.
added 13 commits
March 28, 2024 08:35
…raries from cellar.py file
… citations_adder.py
…changed variable names that were similar to inbuilt ones for eurlex_scraping
…erences for fulltext_saving
…conformity, changed variable names to avoid inbuilt references.
Removed os and sys import.
Extended include to include operative_extractions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The three python files has the code for extraction/scraping of operative part from the documents of the respected Celex Id's and accordingly writes them into csv,json and txt files . For now the txt,json method has been commented under the call function of the class
Writing()in the class ### output.py.