fixes issue 475 MSSQL Unqualified Schema Table Parsing #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macbre
reviewed
Oct 24, 2024
Comment on lines
+31
to
+32
| def test_simple_queries_tables(query, expected): | ||
| assert Parser(query).tables == expected |
There was a problem hiding this comment.
Thanks for adding the test coverage!
|
@T-Santos - thanks for the fix, merging. |
|
@macbre if you have a moment, would you be able to put out a python release so I'm able to pull the package (or inform me how I'm able to do so. I poked around a bit and didn't see any options for me to trigger a release but I certainly could have missed it). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #475