CI: Check that Vim help tags in runtime folder are correct #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychin
added
Infrastructure
ychin
force-pushed
the
check-vimtags-in-ci
branch
2 times, most recently
from
41030d6
to
75f9f1e
Compare
Previously, Vim didn't always have up-to-date help tags. As a result, we just manually generate the help tags when publishing a release (macvim-dev#1286), even though it doesn't actually make sure the tags file in source is actually accurate. However, Vim has since added CI checks to make sure the help tags are correct, so we can change MacVim CI to do the same thing as well. This way, the source version is always correct and we won't rely on a build step during release to fix it, and it also makes sure other methods to get MacVim (build from source, Homebrew) will be correct as well.
ychin
force-pushed
the
check-vimtags-in-ci
branch
from
75f9f1e
to
a356c9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Vim didn't always have up-to-date help tags. As a result, we just manually generate the help tags when publishing a release (#1286), even though it doesn't actually make sure the tags file in source is actually accurate. However, Vim has since added CI checks to make sure the help tags are correct, so we can change MacVim CI to do the same thing as well. This way, the source version is always correct and we won't rely on a build step during release to fix it, and it also makes sure other methods to get MacVim (build from source, Homebrew) will be correct as well.