fix: borrow issue

madara-alliance · Oct 11, 2024 · d42baa4 · d42baa4
1 parent e416c5b
commit d42baa4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/crates/orchestrator/src/jobs/conversion.rs b/crates/orchestrator/src/jobs/conversion.rs
@@ -2,7 +2,7 @@ use std::str::FromStr;
 
 use crate::jobs::{JobError, OtherError};
 
-pub fn parse_string<T: FromStr>(value: String) -> Result<T, JobError>
+pub fn parse_string<T: FromStr>(value: &String) -> Result<T, JobError>
 where
     T::Err: std::fmt::Display,
 {

diff --git a/crates/orchestrator/src/jobs/mod.rs b/crates/orchestrator/src/jobs/mod.rs
@@ -175,7 +175,7 @@ pub async fn create_job(
         KeyValue::new("job", format!("{:?}", job_item)),
     ];
 
-    ORCHESTRATOR_METRICS.block_gauge.record(parse_string(internal_id)?, &attributes);
+    ORCHESTRATOR_METRICS.block_gauge.record(parse_string(&internal_id)?, &attributes);
     tracing::info!(log_type = "completed", category = "general", function_type = "create_job", block_no = %internal_id, "General create job completed for block");
     Ok(())
 }
@@ -262,7 +262,7 @@ pub async fn process_job(id: Uuid, config: Arc<Config>) -> Result<(), JobError>
         KeyValue::new("job", format!("{:?}", job)),
     ];
 
-    ORCHESTRATOR_METRICS.block_gauge.record(parse_string(job.internal_id)?, &attributes);
+    ORCHESTRATOR_METRICS.block_gauge.record(parse_string(&job.internal_id)?, &attributes);
     tracing::info!(log_type = "completed", category = "general", function_type = "process_job", block_no = %internal_id, "General process job completed for block");
     Ok(())
 }
@@ -395,7 +395,7 @@ pub async fn verify_job(id: Uuid, config: Arc<Config>) -> Result<(), JobError> {
         KeyValue::new("job", format!("{:?}", job)),
     ];
 
-    ORCHESTRATOR_METRICS.block_gauge.record(parse_string(job.internal_id)?, &attributes);
+    ORCHESTRATOR_METRICS.block_gauge.record(parse_string(&job.internal_id)?, &attributes);
     tracing::info!(log_type = "completed", category = "general", function_type = "verify_job", block_no = %internal_id, "General verify job completed for block");
     Ok(())
 }